Avoid unnecessary libevent timers in the MessagePump #4258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes an obsolete Starboardization that introduced evtimeval that can cause an overflow on 32-bit platforms with a 64-bit time_t.
Remove the |waiting_| from SbSocketWaiterPrivate that was only read DCHECK() but modified twice for each wait.
jellefoks
requested review from
kaidokert,
andrewsavage1,
y4vor and
aee-google
kaidokert
approved these changes
Oct 15, 2024
jellefoks
force-pushed
the
http3_opts_part_one
branch
from
716de44
to
fd40e76
Compare
andrewsavage1
approved these changes
Oct 15, 2024
Avoid unnecessarily adding libevent timers. This reduces CPU utilization during a download bandwidth test by ~11%.
jellefoks
force-pushed
the
http3_opts_part_one
branch
from
fd40e76
to
8fb9f95
Compare
y4vor
approved these changes
Oct 15, 2024
|
FWIW: b/205134049 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid unnecessarily adding libevent timers in the MessagePump.
This reduces CPU utilization during a download
bandwidth test by ~11%.
b/205134049